briis / smartweather

WeatherFlow Smart Weather Component for Home Assistant
MIT License
108 stars 11 forks source link

Home Assistant 109.0 possibly breaks plugin? #31

Closed whitwhittle closed 4 years ago

whitwhittle commented 4 years ago

Having issues with Plugin following 109.0 upgrade. Worked fine with 108.9

When I run Configuration Validation, get the following message:

Platform error sensor.smartweather - cannot import name 'UNIT_UV_INDEX' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)

If I comment out the sensor: smartweather line in configuration.yaml, I don't get any errors (but of course, I dont have access to sensors).

briis commented 4 years ago

UNIT_UV_INDEX has been replaced by UV_INDEX in HA Constants with 109. Easy to fix. I will release an update tomorrow.

lubbertkramer commented 4 years ago

UNIT_UV_INDEX has been replaced by UV_INDEX in HA Constants with 109. Easy to fix. I will release an update tomorrow.

Great to see you still maintain this component! How are you going to support this in the future, will you accept fixes made by the community to keep this component working? (saw you sold your WF)

briis commented 4 years ago

The breaking change has now been fixed, and there will be a release 1.0.4 available in HACS soon.

@lubbertkramer: I can still support this component, even without the station running locally, as this uses the REST API, and I can just pick another public weather staton to test on. I made a UDP version also, and that one I cannot support anymore, as this requires local HW. Eventually, this component might require major rework, if HA implements new requirements, and by then I am not sure I will do all the work.

briis commented 4 years ago

Closing this .

briis commented 4 years ago

@lubbertkramer: Sorry I did not really answer your question. YES I would love for other people to step in. No doubt this would benefit from some rewrites, and constant maintenance, so all help is appreciated.

Remember, that the communication with the API comes from pysmartweather' so that also needs some love - this was the first thing I ever did in Python, so I know that would benefit from a lot of refactoring

Ideally, converting both modules to using async would be the right thing to do.

lubbertkramer commented 4 years ago

@briis Great to hear, i will keep that in mind and take a look at your code (not the best expert though :) ). I will keep in mind when there will be changes

Note: Update has worked :)

briis commented 4 years ago

My plan now, is to rewrite both the API module (pysmartweatherio) and this component, so that it runs completely Async, and better conforms to HA standards. During that process my plan is to remove the weather part of this component, as DarkSky will not be available in the future, leaving Binary Sensors and Sensors. I will also move to a real Integration, so that configuration will be done from the GUI.

Any thoughts on that?

briis commented 4 years ago

I am now almost done with rewriting the whole Integration. While waiting another user actually found out that WeatherFlow also has a Rest API for their new Forecast Data, so besides new Config Flow setup and Async Support, I have now also replaced DarkSky, with WeatherFlows own Forecast data. HACS will be updated when I have re-written the documentation, but feel free to test by downloading the files in the master branch - remember to remove all yaml references for smartweather before you try this out.

Issue #35 is used to discus the testing.