Feature question: Relative line number

brijeshb42 / monaco-vim

VIM keybindings for monaco editor

https://editor.bitwiser.in/

MIT License

294 stars 30 forks source link

Feature question: Relative line number #124

Open vuhuulan opened 1 week ago

vuhuulan commented 1 week ago

Context: Line number only show definitive number, and not relative number. This makes multi-line operation hard, such as 2jd, 4j, 5k, etc.
Solution: Toggle-able line number via command :relativenumber and :norelativenumber (similar to vim)

CGNonofr commented 1 week ago

Note that that feature is already supported by monaco by setting lineNumbers: 'relative' in the editor options

vuhuulan commented 1 week ago

@CGNonofr Thank you for the response. I see. Coming from Google Colab, I didn't know much about this. Also saw people asking the same question regarding Leetcode vim mode and was pointed to the monaco version that the site used, so I assume it's not about monaco editor?

If that is the case, I first asked the question in colabtools and closed it for duplication (with this one), should I reopen that and close this one instead?

CGNonofr commented 1 week ago

I'm just saying that having relative line numbers are supported out of the box by monaco, monaco-vim just needs to set the appropriate editor setting, it shouldn't be hard to implement