search

brikell69 / nookdevs

Automatically exported from code.google.com/p/nookdevs
0 stars 0 forks source link

Sort by author in nookLibrary #61

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. upload some books to nook 
2. launch nookLibrary
3. sort books by author

What is the expected output? What do you see instead?
The author order based on the field "author sort" from my ebooks.  The 
order currently is bassed on "author" field.

What version of the product are you using? On what operating system?
0.7

Please provide any additional information below.

Original issue reported on code.google.com by hermetica@gmail.com on 1 Apr 2010 at 2:45

GoogleCodeExporter commented 9 years ago 
Many books I had didn't have this tag and that's why I added the author first 
name 
and last name sort options. 

Can you copy a sample opf file for this? 
Also, Any idea how to get this for pdf and pdb files?

Original comment by hari.swa...@gmail.com on 4 Apr 2010 at 11:44

GoogleCodeExporter commented 9 years ago 
Sort by author last name doesn't sort correctly when there is no first name.
Examples: Plato, Confucius, Homer. Plato shows up before Confucius, with Homer 
last.

Original comment by jfe...@gmail.com on 25 Apr 2010 at 10:57

GoogleCodeExporter commented 9 years ago 
ok. I understand the issue. I'll look into the code and see how to fix this.

Original comment by hari.swa...@gmail.com on 25 Apr 2010 at 11:41

GoogleCodeExporter commented 9 years ago 
Looking closer, it seems to fall back to title sort in this case:
Plato - Phaedo
Confucius - The Analects
Homer - The Iliad

I see that with other names as well:
First Name - A Title
Second Name - B Title
First Name - C Title
So, the sorting order seems to be 1. last name, 2. title. And for Plato above, 
that
seems to be considered the first name.
I think it would be better to sort by last name, then first name, then title.

Original comment by jfe...@gmail.com on 26 Apr 2010 at 2:28

GoogleCodeExporter commented 9 years ago 
ok. that sounds good. 
I'll modify author sort to use the full name if either firstname or lastname is 
empty. This will be in the next release.

Original comment by hari.swa...@gmail.com on 26 Apr 2010 at 5:48

GoogleCodeExporter commented 9 years ago 
Thanks. Looks fine in the nookLibrary that you attached to issue #70.
The one difference to the B&N sorting is what I mentioned in the second part of 
my
comment #4.
The B&N sorting:
Adam Author   - A Book
Adam Author   - C Book
Bertha Author - B Book

The nookLibrary sorting:
Adam Author   - A Book
Bertha Author - B Book
Adam Author   - C Book

If the nookLibrary would do the sorting as it is in the B&N sorting, it would be
perfect ;-)

Original comment by jfe...@gmail.com on 27 Apr 2010 at 5:55

GoogleCodeExporter commented 9 years ago 
oh ok. I didn't understand your original comment. I understand now. It's just a 
small change. I'll include it in the next build - probably Friday.

Original comment by hari.swa...@gmail.com on 27 Apr 2010 at 6:40

GoogleCodeExporter commented 9 years ago 
I think this issue is fixed now.

Original comment by hari.swa...@gmail.com on 28 Jul 2010 at 2:05

GoogleCodeExporter commented 9 years ago 
Definitely. I actually came across this issue a couple days ago again and was 
thinking, this has long been fixed and should get closed...
Thanks for your work on this, btw.

Original comment by jfe...@gmail.com on 28 Jul 2010 at 2:09