search

brikis98 / docker-osx-dev

A productive development environment with Docker on OS X
http://www.ybrikman.com/writing/2015/05/19/docker-osx-dev/
MIT License
1.43k stars 106 forks source link

Separate sync and watch for separate control #105

Closed aforward closed 9 years ago

aforward commented 9 years ago

I did not see much movement on

https://github.com/brikis98/docker-osx-dev/pull/80

But I did see a request to separate out "watch" as well.

A few points. The "sync" command is a little ambiguous now (i.e. it will watch AND sync), but I was more concerned with backwards compatibility so I kept it as-is. In the same vein I added "-only" on to sync and watch for performing those tasks separately.

From a bash naming convention, I took the advice from the PR above and called then functions "sync" and "watch" (not "sync_only" and "watch_only"), and then when reacting to user inputs, we either just call sync, just call watch, or call both sync AND watch.

brikis98 commented 9 years ago

Thanks for the PR. The naming changes look good. Just a few comments above to look into.

brikis98 commented 9 years ago

Is the watch function still calling sync? Should it be calling do_sync now?

aforward commented 9 years ago

do_sync on the watch, my refactor mistake, should be updated now

brikis98 commented 9 years ago

Fantastic, thank you.