search

brikis98 / docker-osx-dev

A productive development environment with Docker on OS X
http://www.ybrikman.com/writing/2015/05/19/docker-osx-dev/
MIT License
1.43k stars 106 forks source link

Fix VirtualBox shared folder detection when using boot2docker #128

Closed ejones closed 8 years ago

ejones commented 8 years ago

When initializing boot2docker, check_for_shared_folders is being called before the DOCKER_HOST_SSH_COMMAND variable, which it uses, is intialized. This has the effect of running commands locally instead of on the boot2docker instance and, in this case, silently failing to detect shared folders.

Moving check_for_shared_folders to the end of init_boot2docker fixes this.

This seems to have been caused by the shift from using VBoxManage for shared folder detection to boot2docker ssh, and then to the DOCKER_HOST_SSH_COMMAND variable, without changing when check_for_shared_folders is run.

brikis98 commented 8 years ago

Thanks for the PR! I added one comment. Let me know your thoughts, and if you update the PR, let me know, as GitHub doesn't automatically send a notification for that.

brikis98 commented 8 years ago

Thank you!