search

brikis98 / docker-osx-dev

A productive development environment with Docker on OS X
http://www.ybrikman.com/writing/2015/05/19/docker-osx-dev/
MIT License
1.43k stars 106 forks source link

Brew Cask dependency shouldn't break installation #146

Open ain opened 8 years ago

ain commented 8 years ago

If Brew Cask isn't used on any of the dependencies, it shouldn't be a breaking dependency?

brikis98 commented 8 years ago

Hm... It used to be a requirement to install VirtualBox. However, at some point, the brew_install call for VirtualBox disappeared. Is it installed by something else?

ain commented 8 years ago

VirtualBox was removed in 56edcdbe3f65d3c23677ca7dbacbdc5678047ecd by PR #55.

Generally, VirtualBox is also part of Docker Toolbox that delivers most of the dependencies.

ain commented 8 years ago

@tsupertramp was there a particular reason why you removed VirtualBox from the dependencies?

I'd actually rather have it in there as we have everything else. The original implementation does make sense.

ain commented 8 years ago

Considering the feedback from other topics, Brew Cask dependency should be restored.

ejones commented 8 years ago

@ain @brikis98 what's the verdict here re: VirtualBox as a dependency? The project README only lists Homebrew as a prerequisite. We should either add VirtualBox/Docker Toolbox there or add VirtualBox back to the brew dependencies.

brikis98 commented 8 years ago

Usually, the goal is to put as little into docker-osx-dev as possible. If docker-toolbox installs most of what we need, we should use that, let it handle the details, and remove the rest.

ain commented 8 years ago

I agree with @brikis98 since Docker Toolbox delivers:

I'd propose removing all functions that try to install them and have a dedicated Requirements section in README instead.

VirtualBox should just make a separate bullet point in README.