search

brikis98 / docker-osx-dev

A productive development environment with Docker on OS X
http://www.ybrikman.com/writing/2015/05/19/docker-osx-dev/
MIT License
1.43k stars 106 forks source link

Download rsync binary as 'rsync' and not 'rsync?action=raw' #156

Closed philipn closed 8 years ago

philipn commented 8 years ago

Currently, if docker-osx-dev sync is run and the rsync binary isn't present on the host VM, docker-osx-dev sync, will attempt to download a file named rsync?action=raw. This looks like it should instead be rsync, as I get something like the following otherwise:

Downloading: rsync.tcz
Connecting to repo.tinycorelinux.net (89.22.99.37:80)
wget: can't connect to remote host (89.22.99.37): Connection refused
md5sum: rsync.tcz.md5.txt: No such file or directory
Error on rsync.tcz
exit status 1
exit status 127
2015-12-14 17:37:46 [INFO] Failed to install rsync using tce-load, falling back to install rsync from pre-built binary in docker-osx-dev GitHub repo
Connecting to github.com (192.30.252.131:443)
Connecting to github.com (192.30.252.131:443)
Connecting to raw.githubusercontent.com (199.27.79.133:443)
rsync?raw=true       100% |*******************************|  1469k  0:00:00 ETA
chmod: /usr/local/bin/rsync: No such file or directory
exit status 1
brikis98 commented 8 years ago

Thanks for the PR! It looks like #155 fixes the same issue and I just merged it in. Give it a shot and let me know if it works.