brikis98 / docker-osx-dev

A productive development environment with Docker on OS X
http://www.ybrikman.com/writing/2015/05/19/docker-osx-dev/
MIT License
1.43k stars 106 forks source link

Use only Docker Machine #173

Closed devotox closed 8 years ago

devotox commented 8 years ago
brikis98 commented 8 years ago

Thanks for the PR! A few requests:

  1. There are several unrelated changes here combined into a single PR, which makes it harder to review now and to understand/debug later. Could you create separate PRs for a) removing boot2docker, b) adding the --run-command, c) adding support for config.fish
  2. Please fix the failing tests

Thanks!

devotox commented 8 years ago

Alright that sounds good ... I will do that very soon. One thing have you tried this with an Ember app ... for some reason no matter what i do i get these

 2016-02-18 17:57:04 [INFO] cannot delete non-empty directory: intranet/tmp/babel-input_base_path-uk7StRBr.tmp
-e 2016-02-18 17:57:04 [INFO] rsync: opendir "/Users/devonte/Downloads/platform/intranet/tmp/babel-input_base_path-tqG6KEEz.tmp" failed: Permission denied (13)
-e 2016-02-18 17:57:04 [INFO] cannot delete non-empty directory: intranet/tmp/babel-input_base_path-tqG6KEEz.tmp

My docker compose file has this for the ember app

 volumes:
            - /www/platform/intranet/bower_components
            - /www/platform/intranet/node_modules
            - ./intranet:/www/platform/intranet
            - npm_cache:/root/.npm
            - logs:/var/log
            - tmp:/tmp
brikis98 commented 8 years ago

Please file a separate issue for that. I'm guessing the issue is that you need to tell docker-osx-dev to ignore those /tmp folders.

devotox commented 8 years ago

Before raising it has a problem. I just wanted to make sure I wasn't doing anything wrong. I had the tmp folder in my dockerignore and then the tmp and dist and then also just the dist. No dice