brikis98 / docker-osx-dev

A productive development environment with Docker on OS X
http://www.ybrikman.com/writing/2015/05/19/docker-osx-dev/
MIT License
1.43k stars 106 forks source link

case issue with Caskroom #181

Closed jnoleau closed 8 years ago

jnoleau commented 8 years ago

https://github.com/brikis98/docker-osx-dev/blob/master/src/docker-osx-dev#L739

The result is :

Error: Tap caskroom/cask remote mismatch.
https://github.com/caskroom/homebrew-cask != https://github.com/Caskroom/homebrew-cask

brew tap Caskroom/cask > brew tap caskroom/cask seems to work

brikis98 commented 8 years ago

Ah, Cask has had a fair number of changes recently, so this must be one of them. Do you have any interest in submitting a one-character PR? :)

jnoleau commented 8 years ago

done (yes for testing purpose (this is my first PR on a public project) ^^)

PS :

instead of docker-compose & docker-machine from brew I use dockertoolbox (containing compose, machine, boot2docker iso, kitematic) from cask in my project, I don't know if it is interesting for this tool

brew_install "dockertoolbox" "docker-machine" "docker-machine" true

brikis98 commented 8 years ago

Thanks for the PR! It's now merged.

Using docker toolbox is something we've discussed before (#132) and would be worth another PR.