Replace docker-compose.yml file reading with config command

brikis98 / docker-osx-dev

A productive development environment with Docker on OS X

http://www.ybrikman.com/writing/2015/05/19/docker-osx-dev/

MIT License

1.43k stars 106 forks source link

Replace docker-compose.yml file reading with config command #197

Closed genezys closed 7 years ago

genezys commented 7 years ago

Replace the file reading with the command docker-compose config that will use all configuration files (extends, overrides) & will resolve relative volume paths
Tweak regexp to only parse volumes starting with a / since paths are resolved by docker-compose, this prevents named volumes from being parsed

Fix #64 and #168

genezys commented 7 years ago

All tests pass on my machine.

I did not add tests for named volumes, it may be a good idea to add some but I do not really know where to start.

genezys commented 7 years ago

Thanks for the feedback. Do you prefer I make another commit or amend the existing one?

brikis98 commented 7 years ago

New commits would be great. Thanks!

brikis98 commented 7 years ago

Oh, and let me know when you've updated things, as GitHub doesn't give me a notification for new commits being pushed.

genezys commented 7 years ago

@brikis98 I added both tests and an example output. I also fixed the style of the only new if that was added by my code, I did not touch the other ones. I also renamed the variable for clarity.