brikis98 / infrastructure-as-code-talk

Sample code for the talk "Infrastructure-as-code: running microservices on AWS with Docker, ECS, and Terraform"
http://www.ybrikman.com/writing/2016/03/31/infrastructure-as-code-microservices-aws-docker-terraform-ecs/
573 stars 163 forks source link

no latest tag on gruntworks docker images #4

Closed Cinderhaze closed 8 years ago

Cinderhaze commented 8 years ago

Minor squibble, there are no 'latest tags' on https://hub.docker.com/r/gruntwork/rails-frontend/tags/ or https://hub.docker.com/r/gruntwork/sinatra-backend/tags/, so you are unable to run docker-compse up to test this out without modifying the docker-compose.yaml to include :v1 on both images.

brikis98 commented 8 years ago

@Cinderhaze Thanks for catching this!

@josh-padnick Could you take a look?

Cinderhaze commented 8 years ago

You use the v1 tag in your terraform scripts, it's just missing in the docker-compose.yaml file

On Wed, Oct 12, 2016 at 6:03 AM, Yevgeniy Brikman notifications@github.com wrote:

@Cinderhaze https://github.com/Cinderhaze Thanks for catching this!

@josh-padnick https://github.com/josh-padnick Could you take a look?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brikis98/infrastructure-as-code-talk/issues/4#issuecomment-253171773, or mute the thread https://github.com/notifications/unsubscribe-auth/AG4iiFhO-IrK-Op7e5is4YtQPNPMHv39ks5qzLBjgaJpZM4KUUJB .

~ Daryl Wiest

brikis98 commented 8 years ago

@Cinderhaze Yes, the Terraform scripts should always use a specific version of the Docker images. However, in dev, which is where you use docker-compose.yml, it's typically better to stick with "latest" so you don't have to change it every time you create a new image. Hopefully, @josh-padnick can push the v1 image to latest.

josh-padnick commented 8 years ago

Fixed by #5.