search

brikis98 / ping-play

BigPipe streaming for the Play Framework
MIT License
307 stars 60 forks source link

upgrade to play 2.5 #28

Open domdorn opened 8 years ago

domdorn commented 8 years ago

they've migrated to akka streams.. lib doesn't work anymore :/

brikis98 commented 8 years ago

Yes, that's a bit unfortunate. I thought their plan had been to maintain backwards compatibility with Iteratee/Enumerator stuff until Play 3.x, but looks like that's not the case. I suspect it's a decent amount of work to do this upgrade and am not sure when I'll be able to get to it. PRs welcome :)

rocketpages commented 8 years ago

I'm very interested in this upgrade for a project I'm working on. Trying to prioritize against other things, but I may start chipping away at it.

AbhinabKanrar commented 8 years ago

As far I understand, ping-play is based on scala. The javaapi would internally call scala api while rendering streams. And, scala would depend on Play's own Future API for asynchronous programming.
Now Play 2.5 edition is focusing on Java 8 CompletionStage for asynchronous nature(for Java people). And I think Play would entirely move into CompletionStage way in next couple of build. In this case, what to do? Do we need to rebuild entire architecture? Or, some minor patches would do the things?

brikis98 commented 8 years ago

@Abhinabyte Play 2.5 introduced Akka Streams as a replacement for Iteratees. That's what ping-play should use as well, both for Java and Scala APIs.