Chapter 4: db_remote_state_* hard-coded in book but variables in examples

brikis98 / terraform-up-and-running-code

Code samples for the book "Terraform: Up & Running" by Yevgeniy Brikman

http://www.terraformupandrunning.com/

MIT License

2.92k stars 1.93k forks source link

Chapter 4: db_remote_state_* hard-coded in book but variables in examples #16

Closed mjuenema closed 7 years ago

mjuenema commented 7 years ago

I noticed that in chapter 4 in the book the db_remote_state_bucket and db_remote_state_key arguments in the module "webserver_cluster" example are hard-coded (albeit with a place-holder (YOUR_BUCKET_NAME) value for db_remote_state_bucket) but on Github those arguments are variables defined in vars.tf.

brikis98 commented 7 years ago

Yes, there are minor changes from the book to the sample code, mostly so I could easily run the sample code through automated tests.

brikis98 commented 7 years ago

Is this causing any problems for you?

mjuenema commented 7 years ago

No not at all.