search

brikis98 / terraform-up-and-running-code

Code samples for the book "Terraform: Up & Running" by Yevgeniy Brikman
http://www.terraformupandrunning.com/
MIT License
2.87k stars 1.92k forks source link

Review Chapter 01 #31

Closed riferrei closed 5 years ago

riferrei commented 5 years ago

This PR essentially introduces two changes in the code:

1) Add the installation of Git, which the previous version assumes that it was installed; 2) Introduces a new bash script that is non-based on Debian (Ubuntu) and can be used by machines with RHEL, Fedora, CentOS and hopefully MacOS.

-- Ricardo

brikis98 commented 5 years ago

Thanks for the PR!

A couple thoughts:

  1. All the work for the 2nd edition is in the 2nd edition branch: https://github.com/brikis98/terraform-up-and-running-code/tree/2nd-edition. It doesn't make much sense to merge anything new into master right now.
  2. This repo only contains code used directly in the book, and these scripts in particular aren't meant to be used directly; they are just there to illustrate a point about various tools for configuration management. Therefore, the scripts need to be analogous to the other options (e.g., the Ansible examples and the Terraform User Data example) and I'm not sure a RHEL version is necessary.