search

brikis98 / terraform-up-and-running-code

Code samples for the book "Terraform: Up & Running" by Yevgeniy Brikman
http://www.terraformupandrunning.com/
MIT License
2.83k stars 1.9k forks source link

Chapter 2 - "Deploy a Single Server" needs updating now that EC2 classic is retired. #86

Closed jeremy-cxf closed 1 year ago

jeremy-cxf commented 1 year ago

Heya,

Love the book so far.

Micro issue. The chapter 2 the code will no longer work given that EC2 Classic is retired, thus users now need to either reference an existing VPC or go over creating a new one.

Perhaps this might get daunting for those who haven't approached VPC concepts, however, I've noticed the network security bit does go over this at a high level.

I'm sure you're already aware of it, but perhaps acknowledging this on the repo with a bit of a simple edit (referencing the default VPC) can suffice :)

Thanks!

brikis98 commented 1 year ago

Thanks for the heads up. I think this broke 5 days ago when version 4.29.0 of the AWS provider came out. As it turns out, that version has major breaking changes in it, even though it's only marked as a minor release. I've pinged the AWS provider folks in https://github.com/hashicorp/terraform-provider-aws/issues/23625 to see if there is some way to avoid this huge breaking change.

brikis98 commented 1 year ago

Update: as per this comment, this issue has been fixed in 4.30.0 of the AWS provider! So, all the examples should work as-written, just as long as you avoid the buggy 4.29.0 version.

jeremy-cxf commented 1 year ago

👏 yeww. tested and confirmed working :) thanks for nudging them!