brikteknologier / seraph-model

thin model layer for seraph/neo4j (node.js)

MIT License

111 stars 28 forks source link

Including compositions does not follow usual composition naming scheme #121

Closed andyrichardson closed 7 years ago

andyrichardson commented 8 years ago

Compose function

composedModel — the model which is being composed
key — the key on an object being saved which will contained the composed models.
relationshipName — the name of the relationship that is created between a root model and its composed models. These relationships are always outgoing.

Include options

model - the seraph-model that will be read
rel - the relationship relating the root node and this model

Inconsistency in naming is confusing.

andyrichardson commented 7 years ago

122 has been made to fix this issue. Please provide feedback or merge.

jonpacker commented 7 years ago

Hi! Sorry that these two issues stagnated so long. I've merged them and published a new version now. Thanks for the work!