adding properties to relationships

IcanDivideBy0 commented 9 years ago

fixes #64

I just want to check with you guy if generating the relation identifier in cypher by prefixing the node name with rel_ is the right way to go, or if you prefer to use some kind of name generator like this one. I think it might overlap if you have a model named whatever which is related to another model, AND a third model named rel_whatever, all involved in the same query.

If that's fine with you, I'll keep going :

[x] merge relationships properties while read the related models
[ ] ~~ability to filter on relationships properties~~ it looks like this can already be done with model.query
[x] add tests
[x] update README.md

jonpacker commented 9 years ago

I'm reasonably sure that there will be no overlap, if I remember correctly each name property on the save graph is unique. It would be best to add a test that tests that particular situation in any case.

IcanDivideBy0 commented 9 years ago

Hello, this is ready to be reviewed :)

highfivedenis commented 9 years ago

:+1:

yann-yinn commented 9 years ago

:+1:

jonpacker commented 9 years ago

This looks great. Thanks for your contribution, and sorry it took so long to get around to reviewing it.

jonpacker commented 9 years ago

published as v0.10.0

jonpacker commented 9 years ago

sorry, meant v0.7.0

IcanDivideBy0 commented 9 years ago

@jonpacker thanks, i'll get around and see what i can do with other issues.

brikteknologier / seraph-model

adding properties to relationships #86