search

brikteknologier / seraph-model

thin model layer for seraph/neo4j (node.js)
MIT License
111 stars 28 forks source link

matching unicode and space characters #89

Closed IgorRubinovich closed 9 years ago

IgorRubinovich commented 9 years ago

Thanks for the great module, I'm using it for a promising project. While working on the project I found I can't match unicode regular expressions. Changing lib/model.js line 255 to (?isu) [(?s) dot matching whitespace (?u) matching unicode] helped me a lot. It would be nice not to have to keep a fork only for this change. I realize there might be considerations against it, and an even better way would have been to make it configurable. So here it is for further discussion.

jonpacker commented 9 years ago

Sounds fine to me :) publishing now.

jonpacker commented 9 years ago

You accidentally committed a whole ton of noise in that PR, so I'll just manually patch your change in.

IgorRubinovich commented 9 years ago

sorry about the bad pull request, will take care next time