search

brikteknologier / seraph-model

thin model layer for seraph/neo4j (node.js)
MIT License
111 stars 28 forks source link

Schema Validators - JSONSchema, etc #90

Open panthershark opened 9 years ago

panthershark commented 9 years ago

Thank you for making this module. It has been very helpful.

Would you consider merging a PR that replaced the custom validation code in seraph-model with JSONSchema since it is a standard and has some extra features?

We are migrating to swagger.io for our API definitions and it also uses JSONSchema. We are writing a swagger API generator that takes seraph-models and creates a swagger config. If the schema in seraph-model was already JSONSchema then it would be nice.

If you are not into replacing it, how do you feel about making the schema validator pluggable so it can be replaced?

jonpacker commented 9 years ago

I think the best solution would be to make it pluggable, so that it's backwards compatible. I'm totally open for that.

richard-engineering commented 6 years ago

Ewwww JSON schema. I much prefer validate.js or joi