search

brillout / awesome-vue-refactor

A curated list of awesome things related to Vue.js
38 stars 15 forks source link

[vue-fullstack] updated #26

Closed erguotou520 closed 7 years ago

erguotou520 commented 7 years ago

@brillout Great thanks for your hard work. I am the author of vue-fullstack. I have push a commit to update the readme which contains vue version description and update the github topics.

brillout commented 7 years ago

The demo https://vf-backend.herokuapp.com/ doesn't seem to work? I get Uncaught TypeError: o is not a function in the web console.

Great thanks for your hard work

Thanks:)

erguotou520 commented 7 years ago

It's ok now after updating the dependencies.

brillout commented 7 years ago

Would be nice if the demo is in English as well

erguotou520 commented 7 years ago

The demo support i18n in login page and profile setting dialog while the default is ch_ZN

brillout commented 7 years ago

Is there a language toggle somewhere in the demo? Didn't find any

erguotou520 commented 7 years ago

At the bottom of the login page. image

and the profile setting after login image

Any suggestion about the switch position?

brillout commented 7 years ago

Ah, I didn't see the button because the background image has a similar color than the button's background color.

Also, the app is very slow sometimes.

erguotou520 commented 7 years ago

What does slow mean? Maybe the slow network as it was deployed on heroku.

brillout commented 7 years ago

More than 5 seconds. It's ok though.

I find the not-so-visible button more disturbing. (Especially when the screen is small then the button goes bellow the mountain and get's even less visible.) How about making English the default?

erguotou520 commented 7 years ago

I have changed the language switch button to the main login area. The default language is read from localStorage > navigator.language > 'zh-CN', so the lang should be 'en' when you logged in first time(accounding to your compute locale). This is more reasonable in my option. The demo is running on heroku so that the demo page may be slowly, but I think it's acceptable as it is just a demo.

brillout commented 7 years ago

See PR https://github.com/vuejs/awesome-vue/pull/1001

erguotou520 commented 7 years ago

Thanks for your hard work again.