search

brillout / goldpage

Page Builder.
Creative Commons Zero v1.0 Universal
57 stars 3 forks source link

Goldpage does not work on windows #21

Open estyrke opened 4 years ago

estyrke commented 4 years ago

When running goldpage build (or goldpage dev) on windows, an internal error occurs (unfortunately I don't have a windows box to try on now, but the error is very terse anyway). It seems related to the assumption that paths are separated by forward slashes, which is not the case on windows.

brillout commented 4 years ago

That's possible. I don't have a windows box right now but I'll have a look at it later.

brillout commented 4 years ago

Goldpage doesn't support Windows for now. Comment this ticket if you want windows support.

littleninja commented 3 years ago

I'm doing a bit of research and discovered Goldpage, love its focus on do-one-thing-do-it-well! Knowing my team works primarily on Windows (I'm on MacOS), we might give Goldpage a spin with WSL but this would be a non-starter for us.

Assuming this issue may one day be closed as "Won't Fix", it'd be great if there was a note in the README with platform support.

It seems related to the assumption that paths are separated by forward slashes, which is not the case on windows.

This tickles my curiosity but I'm not on Windows. I wonder if path.join() or cross-env (now in maintenance, alternatives include env-cmd or @naholyr/cross-env) could help.

brillout commented 3 years ago

Hi @littleninja !

I will have another look and tentatively write a patch.

brillout commented 3 years ago

I'll write a patch tentivally next week. In the meantime, WSL should work.

brillout commented 3 years ago

@littleninja Still interested? I've capacity today to write the patch.

littleninja commented 3 years ago

Sorry for the delay, I hope my comment didn't come across in a way that shifted priorities. There's no urgency on my part. 😔

brillout commented 3 years ago

No worries.

There's no urgency

You may wanna wait on https://github.com/reframejs/goldpage/issues/24 then. It's going to be lovely.

If you don't mind me asking; what exactly are your plans with Goldpage? We can discuss in depth about whether Goldpage is/will be a good fit for you, and it's insightful for me to talk about my users' use cases.

brillout commented 3 years ago

@littleninja FYI https://github.com/brillout/vite-plugin-ssr

brillout commented 3 years ago

@littleninja https://github.com/brillout/vite-plugin-ssr is pretty much done and I published a beta. I'd be curious to know what you think.