Closed DoubleJ-G closed 2 years ago
Neat, love it.
Thanks for respecting the HTML-only approach 👌.
Some thoughts:
Super looking forward to this :-)
I do love the vuepress/vitepress powered search functions. I did dig into them to see if it was a library they relied on we could use as well but it seems they roll their own implementation here around @docsearch/js and possibly more styling provided by @docsearch/css.
I did try in the Navigation on the left at first but I think I remember it looking a bit weird with how the results are shown currently, happy to re-visit it and look at the options of making a popup component for the search instead.
Yea would be nice to get as close as possible to Vite's Alogia integration :-).
But no rush / no worries if don't do it.
Super looking forward to this 😊.
Neat thing: it will also then be added to https://telefunc.com/ :-). (Note that Telefunc is work-in-progress and not released yet.)
between "LOGO vite-plugin-ssr" and the social icons.
Or right below the social buttons.
Neat thing: it will also then be added to https://telefunc.com/ :-). (Note that Telefunc is work-in-progress and not released yet.)
Maybe you do want to have the api key and index name in an environment variable then if it's going to be used with multiple docs? It's just hard coded at the moment because it doesn't need to be secret, but env variables would also give you flexibility over the project it's used in.
Closing in favor of https://github.com/vikejs/libframe/pull/4.
This adds in the search functionality discussed in #216. It uses the Algolia js and css provided in the snippet.
Users can also press ctrl+k to focus on the search input like most sites implement today.
The styling is fairly basic other than what Algolia provide, feel free to change.