search

brillout / vite-plugin-mdx

Vite Plugin for MDX
MIT License
115 stars 36 forks source link

Another plugin usage example #35

Open msakrejda opened 3 years ago

msakrejda commented 3 years ago

Similar to #31, but for remark-frontmatter and remark-mdx-frontmatter, which are plugins I'm interested in getting working (and since the main README claims remark-frontmatter as a working plugin, it'd be nice to document how to set that up). #31 should be merged first and then I can rebase on top of it--for now the history of the branch is ugly because I just forked that example (thanks for the project structure @icew4ll!), but I can clean that up (probably by integrating the two versions of the example into one).

I actually set out to document how this does not work right now, but with some help from remark-mdx-frontmatter maintainers, I got it working.

TODO:

See also #30.

brillout commented 3 years ago

@ajstrand @aleclarson Anyone up for reviewing this? I'm swamped with work for Vike :-).

msakrejda commented 3 years ago

No need to review anything yet--I created the PR in draft mode because I think #31 should land first (though I guess it's been a while--if you think that PR is abandoned by the author, I can merge their changes into my PR and we can just continue here instead.)

ajstrand commented 3 years ago

@brillout i can review whenever @uhoh-itsmaciek says the PR is ready for review.

brillout commented 3 years ago

I can merge their changes into my PR and we can just continue here instead.

Yes, I just closed https://github.com/brillout/vite-plugin-mdx/pull/31.

@brillout i can review whenever @uhoh-itsmaciek says the PR is ready for review.

Neat 😊