search

brillout / vite-plugin-mdx

Vite Plugin for MDX
MIT License
115 stars 36 forks source link

Update package.json #39

Closed stefanlivens closed 3 years ago

stefanlivens commented 3 years ago

Updated esbuild to ^0.13.8, this is needed due to newer way of installing/packaging esbuild (so we can use storybook-vite-builder in our not-to-the-internet-connected CI server)

brillout commented 3 years ago

There are lot of breaking changes; does it still work?

stefanlivens commented 3 years ago

I'll be honest, no I didn't test. Because I had no clue how you used esbuild in your code. Now I understand better, and this might be not a good idea to merge without testing. For me that's a bit difficult, because I don't use mdx to write my stories. Maybe it is better I have a chat with the authors of storybook-builder-vite to make this plugin optional?

brillout commented 3 years ago

Superseded by https://github.com/brillout/vite-plugin-mdx/pull/40