search

brillout / vite-plugin-mdx

Vite Plugin for MDX
MIT License
115 stars 36 forks source link

chore: fix build error & make sure plugin hooks always exist #53

Closed csr632 closed 2 years ago

csr632 commented 2 years ago

Fix build error mentioned in https://github.com/brillout/vite-plugin-mdx/pull/52#issuecomment-1239692358

brillout commented 2 years ago

👍

Btw I can give you npm publishing writes if you want.

brillout commented 2 years ago

Released in 3.5.11.

csr632 commented 2 years ago

Btw I can give you npm publishing writes if you want.

I am the original owner of the npm package "vite-plugin-mdx". 😁 Do you remember this issue: https://github.com/vitejs/vite-plugin-react-pages/issues/6

I am willing to keep sending some PRs here! And help you publishing it. (I think I still have the npm publish right)

brillout commented 2 years ago

I do 😀. I actually checked if you are listed as npm owner. I had overlooked you, and I'm just seeing that you actually still are 😀. So, feel free to publish :-). I improved the release script FYI.

brillout commented 2 years ago

I just added you to the repo.

csr632 has been added as a collaborator on the repository.

Feel free to commit directly to master. Honestly, I don't understand the code anymore, it has been changed so much since I last touched it 😀.

brillout commented 2 years ago

We can also move the repo under your GitHub name, if you want. As you wish really :-).

csr632 commented 2 years ago

We can also move the repo under your GitHub name, if you want.

I am ok to keep it under your GitHub name. I don't have big iterate plan for it currently. 😜