search

brillout / wildcard-api

Functions as API.
MIT License
368 stars 14 forks source link

feat: unplugin (webpack) #66

Closed Aslemammad closed 3 years ago

Aslemammad commented 3 years ago

This PR tries to enable tool-agnosticism in telefunc.

It's up to @brillout to review, it's not ready & I don't think it's ready for a review.

brillout commented 3 years ago

Nice, does it already work for Vite?

Aslemammad commented 3 years ago

@brillout Yes, for now!

brillout commented 3 years ago

👍 Let's check if it works with other frameworks. I believe there are some Vite specific code in the code though.

Aslemammad commented 3 years ago

Nope! need to research more about and also test it myself! that's why it's not ready yet!

brillout commented 3 years ago

👌

Aslemammad commented 3 years ago

YO YO @brillout, I think this is ready for review (not review exactly, I mean more refactor).

brillout commented 3 years ago

All tests are now passing :-). (Not on Windows nor MacOS though; no clue why 🤔.)

I'll continue reviewing tomorrow, and I'll dig about why the tests are not passing on Windows/MacOS. Confident I'll be able to merge tomorrow.

brillout commented 3 years ago

Alright, ready for merge.

@Aslemammad So I've refactored a bit and made it that the Vite plugin doesn't use unplugin anymore. We still use unplugin but only for Webpack. Unplugin just doesn't add any value for the Vite plugin. Any objection? Also let me know if I broke anything in my refactor?

brillout commented 3 years ago

Btw. the test are still failing on windows (I didn't check why), but let's merge first.

Aslemammad commented 3 years ago

@brillout That was my idea exactly! Vite plugin API is already simple, so no need for unplugin (we may use it in the future) Let's merge this! then i'm going to refactor it for windows for sure!

brillout commented 3 years ago

💯