I figured this one out by running yarn install --inline-builds on Zui commit cb746af and cd'ing to the tmp directory it showed for where it cloned the Brimcap repo. By doing git diff while it was building I could see the following output:
So it looks like the changes from #306 to package.json are simplified during the build process and that's enough to render the build artifacts as "dirty".
Here's verification that the -dirty goes away when using the Brimcap based on this fix branch.
Sadly, even with this change in place, it looks like brimcap -version broke in some other way again with the Monorepo changes in https://github.com/brimdata/zui/pull/2818, but I'm game to fix these problems one layer at a time.
I figured this one out by running
yarn install --inline-builds
on Zui commitcb746af
andcd
'ing to the tmp directory it showed for where it cloned the Brimcap repo. By doinggit diff
while it was building I could see the following output:So it looks like the changes from #306 to
package.json
are simplified during the build process and that's enough to render the build artifacts as "dirty".Here's verification that the
-dirty
goes away when using the Brimcap based on this fix branch.Sadly, even with this change in place, it looks like
brimcap -version
broke in some other way again with the Monorepo changes in https://github.com/brimdata/zui/pull/2818, but I'm game to fix these problems one layer at a time.Fixes https://github.com/brimdata/zui/issues/2840