search

brimdata / zed

A novel data lake based on super-structured data
https://zed.brimdata.io/
BSD 3-Clause "New" or "Revised" License
1.34k stars 67 forks source link

Formatted String Literals #5123

Closed mattnibs closed 1 month ago

mattnibs commented 1 month ago

The commit removes the template literals and replaces them with formatted string literals. F-strings have a similar functionality but the expression substitution only happens on strings prefixed with the 'f' character.

Fixes #4444

mattnibs commented 1 month ago

parser.peg at eb58396 is broken for me. Is it broken for you as well?

$ make -C compiler/parser
/Users/noah/brimdata/zed/compiler/parser/deps/bin/pigeon -support-left-recursion -o parser.go parser.peg
format error:  filename:15114:53: missing ',' before newline in argument list (and 10 more errors)
make: *** [parser.go] Error 6

You are right! Will fix...