brimdata / zed

A novel data lake based on super-structured data
https://zed.brimdata.io/
BSD 3-Clause "New" or "Revised" License
1.34k stars 67 forks source link

parser: Use *ast.ID for identifers #5136

Closed mattnibs closed 3 weeks ago

mattnibs commented 3 weeks ago

The commit changes the AST representation for declaration identifiers as well as parameters in user-defined ops/funcs and over expressions. Previously these were represented as strings but are now represented as *ast.ID which has the advantage of having location information - meaning errors having to do with these nodes can be set to them rather than the parent.