brimdata / zui

Zui is a powerful desktop application for exploring and working with data. The official front-end to the Zed lake.
https://www.brimdata.io/download/
Other
1.8k stars 132 forks source link

don't truncate column when there is empty window space to the right #1976

Open mccanne opened 2 years ago

mccanne commented 2 years ago

Brim will often truncate a column when there is plenty of screen real estate to otherwise avoid the truncation.

For example, this data loaded into a pool with a query of "*" will truncate the set column even though there is space to the right. (at least in my environment with my window size etc):

{name:"ksoftirqd/1",union:|[0,14,27,28]|}
{name:"sshd",union:|[0,15,17,18,20,22,23,24,26,28,31,32,34,35,36,38,39,49]|}
{name:"ls",union:|[0,15,28,36]|}
{name:"swapper/1",union:|[0,23,24,32,36,37]|}
{name:"systemd-resolve",union:|[11,12]|}
{name:"curl",union:|[11,12,14,15,19,24,28,29,31,34,35,36,37,39,40,41,42]|}
{name:"python3",union:|[12,13,14,15,17,18,19,28,39,42]|}
mccanne commented 2 years ago

Screen Shot 2021-11-22 at 6.37.48 AM.png

philrz commented 2 years ago

It seems things have improved somewhat since this issue was first filed. Here's a repro at Brim commit f217c65 from back when this issue was first filed. The app was started fresh with no prior state, so this reflects default window size. The truncation is visible as before.

image

Now here's the same with current Zui commit e17764c showing no truncation with this particular data, helped along by the "..." that indicates some data is intentionally not being shown in the table view.

image

That said, you can still see the faint vertical bar in the column header that shows that less than all of the remaining horizontal real estate was allocated to this wide column. Therefore I'll hold this issue open so we can discuss if more adjustments are still desired.