Open philrz opened 1 year ago
Update: @nwt used depcheck
recently to scrub some of the dependencies in #2737 and it helped but he also found it was not 100% reliable, so we may not soon realize the dream of having automation do all the heavy lifting here.
As pointed out by @jameskerr in #2718:
Since we bumped into #2717 by accident, it got me to wondering if there was an automated tool that could help us sniff out other instances of this problem waiting to bite us. I did a quick search and the first thing I found was the popular
depcheck
tool. Running it at Zui commit 243c348 that's before the fix in #2718 gets merged, indeed we see thatreselect
was flagged in here, so it probably does the trick.That said, I don't have the confidence to just start attacking the code base and making changes based on this output. If we do manage to use it to clean things up, no doubt it'd be good to lock it in as a tool that's run frequently as part of CI so we catch such problems in advance going forward.