brimdata / zui

Zui is a powerful desktop application for exploring and working with data. The official front-end to the Zed lake.
https://www.brimdata.io/download/
Other
1.8k stars 132 forks source link

Text chopped off in "Update Available" pop-up #3074

Closed philrz closed 4 months ago

philrz commented 5 months ago

Repro is with Zui Insiders 1.7.1-2.

At Zui Insiders 1.7.1-1 and earlier, the "Update Available" pop-up looked like this:

image

Starting with 1.7.1-2, the pop-up now has the destination version out of view, and even the visible text is cropped (notice the missing tail on the "p" in "Update").

image

I've confirmed via binary search that this was caused by the changes in #3044.

philrz commented 4 months ago

Verified in Zui Insiders 1.7.1-25, which is based on Zui commit 5fa9071.

Here's the fixed pop-up on macOS that now has the version string visible again.

image

Here's the same on Windows.

image

3082 makes it difficult for me to verify this on Linux, but since it's working on other platforms I'm ok accepting on faith that it's fixed on Linux too. 😄

Thanks @jameskerr!