brimworks / lua-zip

Lua binding to libzip.
80 stars 25 forks source link

CMakeLists.txt fixes for building as nested project #16

Closed cryi closed 3 years ago

cryi commented 3 years ago

Hi,

your current CMakeLists.txt is problematic in case it is included as nested project. I am linking lua-zip statically with all other dependencies built from source so lookups for LIBZIP and LUA are not ideal in this case. So I adjusted CMakeLists.txt to make package lookups only in case LUA_INCLUDE_DIR and LIBZIP_INCLUDE_DIR are not specified.

cmod_zip was renamed to lua_zip because of parent project it would not be obvious what is cmod_zip.

brimworks commented 3 years ago

Thanks for the contribution.