search

brimworks / lua-zlib

Simple streaming interface to zlib for Lua.
273 stars 111 forks source link

Allow lua54 #51

Closed brimworks closed 4 years ago

brimworks commented 4 years ago

Original PR: https://github.com/brimworks/lua-zlib/pull/50

...simply added back an upper bound.

alerque commented 4 years ago

You know Github lets you push to other people's branches when they are PRs on your project right? You didn't have to shuffle to another PR to accomplish this. Unless PR authors uncheck the box, project maintainers automatically get push access to features branches that are open PRs on their projects.

brimworks commented 4 years ago

@alerque wow! I would have never thought that I would be able to push to your repository. That is almost scary to me... but useful in this scenario. I'll keep that in mind for the future.

alerque commented 4 years ago

There has been a checkbox when you open PRs for years now with "allow maintainers to push to this branch". You can't push just anywhere in other's repos, but if they open a PR from a branch on their fork to your project, you can usually push to that branch. I don't know how long it's been on by default, but quite a while I think. It's quite useful to be able to patch up or extend people's contributions before merging.