search

brinc-finance / brinc-bugbounty

Brinc Bug Bounty Program
1 stars 0 forks source link

[FRONTEND] tBRC estimated amount received inaccurate in multi part transactions #1

Open steviezhang opened 3 years ago

steviezhang commented 3 years ago

===========================================

      Thank you for your bug submission!
    Please fill out the information below.

===========================================

Bug Description: Inaccurate estimate of tBRC to be received when doing multi part swaps (eg ETH -> dai -> tBRC)

Expected Behaviour: Buy module displays correct amount to be received with an allowance for slippage.

Actual Behaviour:** // the actual outcome that is different than the expected outcome or error Amount received differs greatly from buy amount, in excess of the slippage tolerance indicated.

Suspected Criticality Level: low

Steps to reproduce:**

  1. Set slippage tolerance to 0.1%
  2. Swap ETH for BRC

System Information: Google Chrome Ubuntu 18.04.4 LTS

Error Message: N/A

Additional Info: image

araskachoi commented 3 years ago

Hello, thank you for your submission! I have tried to reproduce this but i was unable.. Do you think you can give me more specific instructions to reproduce this? This was the result of my transaction with your steps-to-reproduce

Screen Shot 2021-04-22 at 2 10 43 PM

Screen Shot 2021-04-22 at 2 11 59 PM

As you can see, the balance changes: 2829.34 --> 2836.09 (difference = 6.75; screenshot shows that the expected to be received is 6.760027) which looks fine to me

steviezhang commented 3 years ago

Hey, will do later today, sorry for the late response I got busy