search

brinc-finance / brinc-bugbounty

Brinc Bug Bounty Program
1 stars 0 forks source link

[IMPROVEMENT] approve unlimited amount, to save gas #13

Open ariesjia opened 3 years ago

ariesjia commented 3 years ago

===========================================

  Thank you for your submission!
Please fill out the information below.

===========================================

Is this feature request/improvement proposal targeting the front-end application or smart contract? Please try and be as specific as possible. Currently every swap requires approve

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

ETH mainnet is so expensive, we need to make a trade-off between convenience and safety. UNISwap is also ask user to approve unlimited amount

Describe the solution you'd like A clear and concise description of what you want to happen.

Hope to authorize an unlimited amount for the first time

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

araskachoi commented 3 years ago

Hello, thank you for your submission! Very astute of you to notice this. Yes, this is known behaviour and we are working to implement a way to cache your approval so you will not need to re-approve if you have not completed your transaction for your previous approval! This is currently in the pipeline to fix!