search

brinc-finance / brinc-bugbounty

Brinc Bug Bounty Program
1 stars 0 forks source link

[FRONTEND] Constant Re-Approval of tokens required #5

Open Rufia75 opened 3 years ago

Rufia75 commented 3 years ago

===========================================

      Thank you for your bug submission!
    Please fill out the information below.

===========================================

Bug Description: Everytime new trade is begun, re-approval of tokens is required, resulting in additional gas fees for users. This also occurs if user refreshes the page.

Expected Behaviour: Users able to approve tokens once, for a set amount of time (e.g. 1 week) or up to a certain limit of tokens. Not required to re-approve after every trade.

Actual Behaviour:** Everytime new trade is begun or amount, re-approval of tokens is required,

Suspected Criticality Level: Low

Steps to reproduce:**

  1. Approve tokens.
  2. Buy tokens or refresh page.

System Information: Windows 10

Error Message: N/A

Additional Info: // any relevant screenshots that will aid in the investigation process can be added here // any configurations, additional context, or gist

araskachoi commented 3 years ago

Hello, thank you for your submission! Very astute of you to notice this. Yes, this is known behaviour and we are working to implement a way to cache your approval so you will not need to re-approve if you have not completed your transaction for your previous approval! This is currently in the pipeline to fix!