brineylab / abstar

VDJ assignment and antibody sequence annotation. Scalable from a single sequence to billions of sequences.
MIT License
41 stars 17 forks source link

Missing try/except for Bio.Alphabet in abutils/core/pair.py #89

Closed zacmon closed 3 years ago

zacmon commented 3 years ago

There should be

try:
    from Bio.Alphabet import generic_dna
except ImportError:
        generic_dna = 'DNA'

in abutils/core/pair.py similar to the other commits you made recently otherwise abstar 0.4.3 does not work for me immediately after pip installing.

Or perhaps the problem is that upgrading my abstar from 0.3.5 to 0.4.3 didn't also upgrade to the latest abutils . . .

briney commented 3 years ago

Yeah, it looks like an old version of abutils is to blame. I'll update requirements..txt to specify the appropriate abutils version.