search

bringyourownideas / silverstripe-maintenance

Helps with the day by day work to run a SilverStripe application or website.
https://bringyourownideas.com
BSD 3-Clause "New" or "Revised" License
31 stars 10 forks source link

"Latest" shows as "dev-master" with "minimum-stability: dev" #126

Open chillu opened 5 years ago

chillu commented 5 years ago

It's a bit pointless to show the latest dev branch as a release, right? That's not what we want people to upgrade to. This is on installer@4.2.0, not CWP. Maybe it's different in CWP due to recipe constraints?

image

robbieaverill commented 5 years ago

The data we show in this report is essentially just a proxy for composer outdated. We haven't built in any layers of customisation yet, but we can definitely do that. If you take minimum-stability: dev out of your composer.json you might get different results (I realise that you're probably using an out-of-the-box CWP install to test this with)

chillu commented 5 years ago

Good point. Looks like composer outdated doesn't have any switches like --stable-only (https://getcomposer.org/doc/03-cli.md#outdated). But looking at our installers, both the CWP and core one have minimum-stability: dev. So the "latest" column is effectively useless at the moment, unless projects remove that constraint. Which I believe very few people do, because it's usually not realistic. We might as well hide it until we create our own logic to determne "latest stable". This is particularly bad since it won't show people on CWP 1.x that CWP 2.x even exists, right? It'll just show dev-master everywhere, which doesn't help the decision makers which this module targets. /cc @brynwhyman

chillu commented 5 years ago

Maybe that would be an opportunity for a small patch provided back to the composer project, introducing a composer outdated --minimum-stability override?