brinkmanlab / globecorr

https://globecorr.ca/
Other
0 stars 1 forks source link

Saving Globes #9

Closed esgarlock closed 2 years ago

esgarlock commented 4 years ago

Globes people are working on will disappear if they leave the page. Can we get a "bookmark" ability in order for people to save them or share them with others, or at least not lose them if they go to the tutorial? (I know you could just send the exported image, but, might be nice to also be able to send an interactive view)

We would also take advantage of this functionality when we have more example globes to use.

There is currently a warning in the tutorial that users will lose their work if the exit the page.

innovate-invent commented 4 years ago

@fionabrinkman the issue with this is we are not hosting user data. The user would have to send a person the data to load, rather than a bookmark to the page.

fionabrinkman commented 4 years ago

Yes, we are not hosting user data, but could settings be incorporated into a version of a file they download, rather than just a static png download, so they could have someone upload the file? This would have to be a separate file upload, but the worry is that if a user comes up with a globe with certain threshold or colour settings, they can’t share that in any way right now. Welcome thoughts on the easiest implementation of this.

Best wishes, Fiona

On Apr 15, 2020, at 12:04 PM, Nolan Woods notifications@github.com wrote:

@fionabrinkman https://github.com/fionabrinkman the issue with this is we are not hosting user data. The user would have to send a person the data to load, rather than a bookmark to the page.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brinkmanlab/exposomeglobe/issues/9#issuecomment-614223818, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMF575EJXCR5S55DVOLNHDRMYANTANCNFSM4MIZZ66A.

innovate-invent commented 4 years ago

Do you want to capture the just the threshold and colors? or globe state as well (including collapsed domains)?

fionabrinkman commented 4 years ago

Good question. Capturing everything is ideal I guess, but previously when Mariam would link to a globe it would just be set with a particular colour and threshold, so assuming that’s much easier I’d be fine with that as it never seemed to cause an issue.

On Apr 15, 2020, at 2:29 PM, Nolan Woods notifications@github.com wrote:

Do you want to capture the just the threshold and colors? or globe state as well (including collapsed domains)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brinkmanlab/exposomeglobe/issues/9#issuecomment-614289844, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMF57ZUGQROR7D4SHHCWTLRMYRMVANCNFSM4MIZZ66A.

innovate-invent commented 4 years ago

I had a quick look through Mariums original code and I can't see anything that would allow specifying options in the URL. I have added a text field with the options serialized to the settings drawer to make it easier to save and reload. Hopefully this is what you have in mind?

fionabrinkman commented 4 years ago

I’m not clear what you mean? Where is this text field you mention?

Oh wait! I found it. Still noting this above, just so its clear that you need to clarify such points more specifically. Anyway, I think this is not a bad workaround for now. Quite reasonable really, given the simplicity of what we’re trying to do. However, I think its worth checking with Mariam for ideas re other ways we could do this.

Best wishes, Fiona

On Apr 15, 2020, at 5:17 PM, Nolan Woods notifications@github.com wrote:

I had a quick look through Mariums original code and I can't see anything that would allow specifying options in the URL. I have added a text field with the options serialized to the settings drawer to make it easier to save and reload. Hopefully this is what you have in mind?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/brinkmanlab/exposomeglobe/issues/9#issuecomment-614342911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMF577O6D5VR6P2YEH4IDTRMZFBBANCNFSM4MIZZ66A.

innovate-invent commented 4 years ago

There are a number of ways we could communicate these settings. A file download was too heavy weight to store 3 values. Storing the values in the URL doesn't make sense because you would still have to upload the file. Unless we go so far as to write out the user data with the settings back to a file, the setting will always be loosely coupled to the data.

innovate-invent commented 2 years ago

resolved by 21fd11e88a394f8dd3c4b536e856b8b0a6695946