search

brinktrade / brink-core

Core smart contracts for Brink accounts
GNU General Public License v3.0
12 stars 7 forks source link

Audit Issue 30: Make proxy storage variables public #26

Closed Kyrrui closed 2 years ago

Kyrrui commented 2 years ago

OPINION: Unnecessary change that increases gas cost

mikec commented 2 years ago

@Kyrrui I agree that the gas cost increase is not worth the change. Seems like the explicit getters and internal storage variables makes the bytecode of the Proxy contract slightly smaller than using public storage variables.