brinktrade / brink-core

Core smart contracts for Brink accounts
GNU General Public License v3.0
13 stars 7 forks source link

check size of bytes data to ensure it contains a function call #41

Closed mikec closed 2 years ago

mikec commented 3 years ago

I implemented this to see what the gas cost would be, but I'm leaning toward not merging it because it increases gas cost and doesn't add any real security benefit. There is still a risk of signing to a malicious verifier, it doesn't substantially decrease that risk to explicitly invalidate signed empty data or data with less than 4 bytes (functional signature)