Migration SignatureDataConversion to .NET Core

brinley / jSignature

jQuery plugin for adding web signature functionality

http://www.unbolt.net/jSignature

691 stars 529 forks source link

Migration SignatureDataConversion to .NET Core #114

Closed ghost closed 7 years ago

ghost commented 8 years ago

Migration SignatureDataConversion_dotNet project to .NET Core / Visual Studio 2015.

This closes #113

ghost commented 8 years ago

Hi @Brinley,

I have prepared new Pull Request with correct version like you ask, and also updated references to latest version of .NET Core and NUnit.

ghost commented 8 years ago

And sorry for this last commit - I forgot few important files ;)

Please merge all those commits into one :)

brinley commented 8 years ago

Sorry I forgot to respond but you were right about this possibly a breaking check so we should update the major version number instead. I also noticed you updated the tests, have you executed them and they pass?

ghost commented 7 years ago

Ok, version is updated now to v2.

Yes, all tests pass:

tests

brinley commented 7 years ago

Thanks @LukaszDev