search

brinley / jSignature

jQuery plugin for adding web signature functionality
http://www.unbolt.net/jSignature
696 stars 529 forks source link

changed core to add: clarity, more events, functionality plugins. + first such plugin: Undo Button. #20

Closed dvdotsenko closed 12 years ago

dvdotsenko commented 12 years ago

Broke apart gargantuan jSignature initializer that did not change in structure since earlier versions.

Now it's jSignatureClass with externally-specified methods.

This makes the code a bit clearer (easier to read, maintain)

I needed that ^ to add "undo last stroke" code into core.

Instead, I added "functionality extensions hooks" - plugin hooks and added UndoButton as plugin. It all rides on top of PubSub-based event machine, so added more events that fire during jSignature init.

We (Willow Systems) are sufficiently happy now with feature-set of jSignature. So, I don't plan new big features to, rewrites of the core any time soon. Will document the API and push it up.

Daniel.

dvdotsenko commented 12 years ago

This pull request is here to announce "change in core" so people who could be coding / tweaking against it would get familiar earlier, before Docs arrive.

dvdotsenko commented 12 years ago

Demo of the updated code is here http://willowsystems.github.com/jSignature/#/demo/

dvdotsenko commented 12 years ago

I have played around with this version for a bit and rather like it. Don't see any ugly side effects. Will merge. Docs still to follow.