search

brinley / jSignature

jQuery plugin for adding web signature functionality
http://www.unbolt.net/jSignature
696 stars 529 forks source link

extraneous shadows and lines in IE10 #45

Open CSDiris opened 10 years ago

CSDiris commented 10 years ago

In IE10 we are experiencing extraneous shadows and lines around the signature. They do not appear in any other browser we have used. I have pasted an image to this post from your own demo. We are concerned these lines and shadows will discredit a signature in a legal document. Will you be able to clean them up?

screenshot from 2013-11-18 10 34 20

brinley commented 10 years ago

Hi, can you please try again in IE10 on http://brinley.github.io/jSignature toggle the export format until you get one that shows the image in the display area below and tell me if the additional lines still appear.

CSDiris commented 10 years ago

When I toggle through the export formats the one that does not display the additional lines is SVG. However I did get that format from this link: http://willowsystems.github.io/jSignature/#/demo/

brinley commented 10 years ago

Can you try it on my link instead and tell me if the redrawn image contains the extra lines. willowsystems's jSignature is a fork of my jSignature so their code may be slightly different so I'm only concerned if my version is affected.

CSDiris commented 10 years ago

I just tried it on http://brinley.github.io/jSignature . "image" was the only choice that displays an image below and yes the lines still appear.

MarcGodard commented 10 years ago

I can confirm this. Extra lines show up only in IE.

brinley commented 10 years ago

Sorry for the lack of activity, I can confirm that there's an issue but I've not been able to find a solution yet. Keeping the line width to the minimum reduces that extraneous lines but is not a reasonable fix. I'll keep investigating, but for now i'm blaming the browser

davemateer commented 9 years ago

The bug is with the shadow settings. We experienced the same problem, and needed this to work on IE10. The following code is more of a workaround than a fix per se. It simply disables all shadow settings. That was good enough for us.

Around line 990 or so in jSignature.js:

if (!isCanvasEmulator){
  ctx.shadowColor = "transparent";
  shadowOffsetX = 0;
  ctx.shadowOffsetY = 0;
  ctx.shadowBlur = 0;
}