search

brint / wordpress-cookbook

Development repository for Opscode Cookbook wordpress
https://supermarket.chef.io/cookbooks/wordpress
Apache License 2.0
80 stars 174 forks source link

[COOK-4180] leverage the database cookbook #16

Closed craigtracey closed 10 years ago

craigtracey commented 10 years ago

Previously, the recipe for adding databases and privileged database users was reimplementing what is available in the database cookbook. Therefore, simply add the database cookbook as a dependency and create the users/databases in a more standard and idempotent fashion.

craigtracey commented 10 years ago

@juliandunn do you perhaps have thoughts on this?

juliandunn commented 10 years ago

@craigtracey I am personally :thumbsdown: on this but mostly because I don't like interacting with MySQL (Windows or Linux) using the Ruby gems, and I think it's something we should actually remove from the database cookbook. Doing so requires:

  1. Crazy compile-time logic
  2. The user to have build-essential (which basically involves them having a C compiler on the system, in addition to -devel libraries, neither of which are desirable on a production host)
  3. Generating binary extensions that are dependent on the version of MySQL installed on the host
  4. Fetching gems from Rubygems.org that may or may not be accessible to hosts that are not connected to the internet (e.g. in enterprise data centers)

So I would personally prefer to leave this as is, knowing that we should really refactor the mysql_* LWRPs to interact with the "mysql" client binary directly, similar to what @realityforge has done in his psql cookbook.

retr0h commented 10 years ago

+1 for this change.

The fact that this recipe has embedded SQL only adds to the complication as shown in https://github.com/opscode-cookbooks/wordpress/pull/20.

someara commented 10 years ago

merged in d068534a85583b0e0e8cb8e5c6c55c927e86d7c1