brint / wordpress-cookbook

Development repository for Opscode Cookbook wordpress
https://supermarket.chef.io/cookbooks/wordpress
Apache License 2.0
80 stars 174 forks source link

Use port 80 by default #35

Closed ryandub closed 10 years ago

ryandub commented 10 years ago

Tying WordPress to all of Apache's listen ports by default is not desirable as you may want other apps on other ports. In addition, Apache's default listen ports are 80 and 443 and the current behavior of this cookbook attempts to create a VirtualHost directive like this:

<VirtualHost *:80 443  >

which is not valid syntax and causes an error.

This patch still allows wrapper cookbooks to specify listen ports for WordPress, but also adds a sane default of port 80.

brint commented 10 years ago

Thanks for the PR, I think we'll need to adjust the Apache template as well.

ryandub commented 10 years ago

Ok, updated the Apache template to remove the multiple ports.

brint commented 10 years ago

Thanks @ryandub! Last thing, could you add the attribute to the README?