search

brint / wordpress-cookbook

Development repository for Opscode Cookbook wordpress
https://supermarket.chef.io/cookbooks/wordpress
Apache License 2.0
80 stars 176 forks source link

wp-config.php permissions are too open #38

Closed ilyash closed 10 years ago

ilyash commented 10 years ago

Database configuration is world-readable

https://github.com/brint/wordpress-cookbook/blob/d3ed7c920a9cef392d5b9752ea2861e7420afb22/recipes/default.rb#L74

brint commented 10 years ago

Hi @ilyash! It looks like those are the stock permissions (from everything I can tell). I'm trying to keep this cookbook close to stock. Maybe we can set it as an attribute with a default of what the stock permissions, but it'd at least give an option of an override. Thoughts?

ilyash commented 10 years ago

Actually I couldn't see anywhere which one is the "stock" cookbook. I got here via the supermarket and it seemed like the official wordpress cookbook. Where is the "stock" cookbook?

If it's your upstream, I'd better file a bug there I guess. It seems the cleanest.

Otherwise (no upstream) it seems better to go with the stricter permissions as defaults. Maybe providing an attribute to override and comment there to file a bug if there is such a need.

What do you think?

brint commented 10 years ago

WordPress config permission attribute added in 1384694.

This is the official WordPress cookbook, I'm listed as a contributor instead of owner in supermarket. Maybe I'll pester them one day to change the ownership.

ilyash commented 10 years ago

Thanks!

On Sat, Aug 23, 2014 at 6:52 PM, brint notifications@github.com wrote:

Closed #38 https://github.com/brint/wordpress-cookbook/issues/38.

— Reply to this email directly or view it on GitHub https://github.com/brint/wordpress-cookbook/issues/38#event-156408205.

Ilya Sher, Coding-Knight LTD. +972 54 8166121 http://coding-knight.com/