briot / geneapro

Genealogical software based on the GenTech data model
http://briot.github.com/geneapro/
GNU General Public License v2.0
33 stars 8 forks source link

There should be a bit longer delay in onchange events, particular for ancestor/descendant selections. #55

Closed changeling closed 5 years ago

changeling commented 5 years ago

It seems that onchange is on a very short delay, triggering updates as soon as a new value is hit, when mouse or arrow-key changes are made to the selected number of ancestors/desc.

Perhaps a second or so at least, or perhaps a Set button to commit the choice, rather than triggering a sequence of pedigree updates.

By way of example, as I rapidly type the right arrow key to reach a higher number, in console I see:

2019-03-24 21:26:06,198 get geneaprove.views.pedigree.PedigreeData.get(<JSONViewParams: {'gens': ['14'], 'descendant_gens': ['1'], 'theme': ['-5']}>)
2019-03-24 21:26:06,198 get_json get pedigree data
2019-03-24 21:26:06,310 get geneaprove.views.pedigree.PedigreeData.get(<JSONViewParams: {'gens': ['15'], 'descendant_gens': ['1'], 'theme': ['-5']}>)
2019-03-24 21:26:06,311 get_json get pedigree data
2019-03-24 21:26:06,361 get geneaprove.views.pedigree.PedigreeData.get(<JSONViewParams: {'gens': ['16'], 'descendant_gens': ['1'], 'theme': ['-5']}>)
2019-03-24 21:26:06,362 get_json get pedigree data
2019-03-24 21:26:06,425 get geneaprove.views.pedigree.PedigreeData.get(<JSONViewParams: {'gens': ['17'], 'descendant_gens': ['1'], 'theme': ['-5']}>)
2019-03-24 21:26:06,426 get_json get pedigree data
2019-03-24 21:26:06,480 get geneaprove.views.pedigree.PedigreeData.get(<JSONViewParams: {'gens': ['18'], 'descendant_gens': ['1'], 'theme': ['-5']}>)
2019-03-24 21:26:06,481 get_json get pedigree data
2019-03-24 21:26:06,587 get geneaprove.views.pedigree.PedigreeData.get(<JSONViewParams: {'gens': ['19'], 'descendant_gens': ['1'], 'theme': ['-5']}>)
2019-03-24 21:26:06,588 get_json get pedigree data
briot commented 5 years ago

Agreed. I have started to introduce such changes, for instance in the filter of All Persons. I will generalize to other views.