Open changeling opened 5 years ago
Here's a 20-generation Pedigree. At files this deep, zooming out and back in makes all the difference.
Pedigree:
Just a side thought, without digging in yet:
The weirdnesses in graphs seem to all occur past 11 generations. The Radial graph seems to stop expanding the radius of the graph and force subsequent generations with the radius. The Fanchart seems to be plotting marriages with a negative value, thus the artifacts mirroring the fan below (Those appear to be Marriage dates.).
As I said, I haven't gone into the code looking yet, and it's still possible it's something going on in my dataset, but I'm thinking something is going on in the creation of the graph.
Here's an example of 11 Generations Radial:
And 12 Generations at roughly the same point:
Go up a few comments to see the Radial at 20 Generations to see how this plays out.
The ManyMany file is around 220,000 people, but many generations, and no descendants, only ancestors. I'm actually no longer sure how many generations (This would be a neat feature for the dashboard, deepest generation in the tree). It might also be a good idea to set the bounds for zooming in the different graphics to the selected generation level. When I have extreme charts, the zoom level is insufficient to get the entire image onscreen.
The GrandSchemeTree, with ~million people, doesn't seem to have any problems, though it's only about 8 generations deep, with 8 generations of descendants.
Pedigree is no problem with the preset themes, one of the ~30 second queries, as are all the others, set to their max. I've even tweaked the various Side.tsx files to go way, way out, and they run fine. I'll try them with custom themes (very cool feature, by the way).
Radial can get weird at the later generations, likely due to problems in the data, or descendants that overlap, as do the Fan charts.
Here are examples of deep Radial and Fan charts:
Radial:
Fan:
Originally posted by @changeling in https://github.com/briot/geneapro/pull/56#issuecomment-478133267